Hello anmolbabu, I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40227 to review the following change. Change subject: engine : Geo-rep JsonRpc refactored ...................................................................... engine : Geo-rep JsonRpc refactored This patch refactors JsonRpcVdsServer geo-rep in accordance with merged vdsm patch. Change-Id: Ibb6354afa4e543fc6e3a8fe669f37ffaee400c53 Signed-off-by: Anmol Babu <anb...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/40227/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java index 2c79f95..2d0279a 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java @@ -1192,7 +1192,7 @@ @Override public StatusOnlyReturnForXmlRpc glusterGeoRepKeysUpdate(List<String> geoRepPubKeys, String remoteUserName) { JsonRpcRequest request = - new RequestBuilder("Gluster.writeGeoRepPubKeys") + new RequestBuilder("GlusterVolume.geoRepKeysUpdate") .withParameter("geoRepPubKeys", geoRepPubKeys) .withOptionalParameter("userName", remoteUserName).build(); Map<String, Object> response = new FutureMap(this.client, request); @@ -1367,8 +1367,8 @@ .withParameter("volumeName", volumeName) .withParameter("remoteHost", slaveHost) .withParameter("remoteVolumeName", slaveVolumeName) - .withParameter("key", configKey) - .withParameter("value", configValue).build(); + .withParameter("optionName", configKey) + .withParameter("optionValue", configValue).build(); Map<String, Object> response = new FutureMap(this.client, request); return new StatusOnlyReturnForXmlRpc(response); } @@ -1382,7 +1382,7 @@ .withParameter("volumeName", volumeName) .withParameter("remoteHost", slaveHost) .withParameter("remoteVolumeName", slaveVolumeName) - .withParameter("key", configKey) + .withParameter("optionName", configKey) .build(); Map<String, Object> response = new FutureMap(this.client, request); return new StatusOnlyReturnForXmlRpc(response); -- To view, visit https://gerrit.ovirt.org/40227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb6354afa4e543fc6e3a8fe669f37ffaee400c53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches