Sandro Bonazzola has posted comments on this change. Change subject: automation: add automation scripts ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/39714/2/automation/build-artifacts.sh File automation/build-artifacts.sh: Line 1: #!/usr/bin/sh > bad shebang, use /bin/sh or /usr/bin/env sh /bin/sh doesn't exist anymore in modern distributions. Ok for using env Line 2: Line 3: # cleanup Line 4: rm -Rf \ Line 5: exported-artifacts \ Line 12: make rpmsuffix=".${GIT_RELEASE}" srpm Line 13: yum-builddep ./ovirt-engine-sdk-python.spec Line 14: make rpmsuffix=".${GIT_RELEASE}" rpm Line 15: Line 16: for file in $(find dist -iregex ".*\.\(tar\.gz\|rpm\)$"); do > I guess ^^ this can fail fixed Line 17: echo "Archiving $file" Line 18: mv "$file" exported-artifacts/ https://gerrit.ovirt.org/#/c/39714/2/automation/check_merged.sh File automation/check_merged.sh: Line 1: #!/usr/bin/sh > bad shebang Done Line 2: https://gerrit.ovirt.org/#/c/39714/2/automation/check_patch.sh File automation/check_patch.sh: Line 1: #!/usr/bin/sh > bad shebang Done Line 2: -- To view, visit https://gerrit.ovirt.org/39714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice348d6a168428c8ec605e11ddb8af7012e12991 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
