Simone Tiraboschi has posted comments on this change. Change subject: storage: gluster: add glusterfs volume provisioning ......................................................................
Patch Set 22: (2 comments) https://gerrit.ovirt.org/#/c/36108/22/src/plugins/ovirt-hosted-engine-setup/storage/glusterfs.py File src/plugins/ovirt-hosted-engine-setup/storage/glusterfs.py: Line 60: """ Line 61: content = [] Line 62: with open(ohostedcons.FileLocations.GLUSTERD_VOL, 'r') as f: Line 63: for line in f.read().splitlines(): Line 64: if line.find('rpc-auth-allow-insecure') != -1: What's if you find option rpc-auth-allow-insecure off ? Line 65: continue Line 66: elif line.find('base-port') != -1: Line 67: continue Line 68: elif line.find('end-volume') == 0: Line 221: def _customization(self): Line 222: """ Line 223: if GLUSTER_PROVISIONING_ENABLED is False, then a remote GlusterFS Line 224: server will be used and validated as if it was a NFS server. Line 225: Control will then move to nfs.py plugin. It doesn't match with the code Line 226: """ Line 227: if self.environment[ Line 228: ohostedcons.StorageEnv.DOMAIN_TYPE Line 229: ] != ohostedcons.DomainTypes.GLUSTERFS: -- To view, visit https://gerrit.ovirt.org/36108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33bb4ef586bbad7fa3e2de29d63e4e6ff9d86bab Gerrit-PatchSet: 22 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Vijay Bellur <vbel...@gmail.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
