Ramesh N has posted comments on this change. Change subject: engine: Georep status detail changes ......................................................................
Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/40207/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java: Line 163: (GlusterGeoRepSessionDetails) May be u can do the conversion once in top and keep it in a variable and re-use it in all the places. Line 164: && Looks like something wrong with formatting. All && coming in separate line https://gerrit.ovirt.org/#/c/40207/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java: Line 26: "checkpointTIme"; "checkpointTIme" => '"checkpointTime" Capital 'I' in Time Line 32: innerMap.containsKey(key) && not required as StringUtils.isNumeric() can handle null values. Line 32: StringUtils.isNumeric(key) I think u have to check the value not the key here. -- To view, visit https://gerrit.ovirt.org/40207 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05fa1d8537bcd3a0a80f1765f142dab575f43ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
