Michael Pasternak has posted comments on this change.
Change subject: restapi: Direct-LUN Disk Creation - Dont Require Size
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java
Line 28:
Line 29: @Override
Line 30: public Response add(Disk disk) {
Line 31: validateParameters(disk, "format", "interface");
Line 32: if (!disk.isSetLunStorage()) {// lun-disk does not require size
you should also check that luns list not empty
Line 33: validateParameters(disk, "provisionedSize|size");
Line 34: }
Line 35: validateEnums(Disk.class, disk);
Line 36: AddDiskParameters params = new AddDiskParameters();
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java
Line 330
Line 331
Line 332
Line 333
Line 334
should be splitted in two test
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-03 15:12:38 +0200
Line 4: Commit: Ori Liel <[email protected]>
Line 5: CommitDate: 2012-10-03 15:16:45 +0200
Line 6:
Line 7: restapi: Direct-LUN Disk Creation - Dont Require Size
where is BZ info?
Line 8:
Line 9: Change-Id: Ie8dba8d1e1b20ff5f81d9cfa944d3bfcd5630bc1
--
To view, visit http://gerrit.ovirt.org/8331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8dba8d1e1b20ff5f81d9cfa944d3bfcd5630bc1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
