Douglas Schilling Landgraf has posted comments on this change. Change subject: persist: /etc/multipath/wwwids ......................................................................
Patch Set 2: Hey Nir, > Douglas, I think this file is created by multipath on the > first time it runs. Did you test that with this patch, > the default multipath wwids file is created? > > It should look like this: > > > > # Multipath wwids, Version : 1.0 > # NOTE: This file is automatically maintained by > multipath and multipathd. > # You should not need to edit this file in normal > circumstances. > # > # Valid WWIDs: Yes, it's exactly this one. I would prefer not us creating the file manually or keeping the original file in our repo as template because the file can change in the future. I just did all those dir validations and the touch command to prevent any "inconsistent image (it should not happen)" to continue the upgrade with the wwwids persisted. We could remove if you guys want. > It would be nice if we can add a note about persisting > this file to the comment. The file is persisted in the hook, I think add a comment won't help because users should no read this file at all. The shell is not supported to ovirt-node users, they should not even know how we handle file. However, if you still prefer or fabian we can do it easily. -- To view, visit https://gerrit.ovirt.org/40187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6b5a6b0bed6521503b972866d93a7da5cd28fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
