Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: drop all-in-one on el6 ......................................................................
Patch Set 2: (5 comments) I'm not willing to support a "demo" installation mixing repositories/channels https://gerrit.ovirt.org/#/c/40162/2/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 43: %global EXTRA_BUILD_FLAGS %{?_ovirt_build_extra_flags:%{_ovirt_build_extra_flags}}%{?ovirt_build_extra_flags: %{ovirt_build_extra_flags}} Line 44: %endif Line 45: Line 46: Line 47: > ? Done Line 48: %if 0%{?fedora} Line 49: %global ovirt_install_systemd 1 Line 50: %global ovirt_install_systemv 0 Line 51: %global ovirt_install_poms 1 Line 49: %global ovirt_install_systemd 1 Line 50: %global ovirt_install_systemv 0 Line 51: %global ovirt_install_poms 1 Line 52: %global ovirt_require_maven 1 Line 53: %global with_aio 1 > ovirt_ prefix please Done Line 54: %if %{fedora} >= 20 Line 55: %global ovirt_provides_jboss 1 Line 56: %global jboss ovirt-engine-jboss-as >= 7.1.1 Line 57: %else Line 77: %global ovirt_provides_jboss 1 Line 78: %global jboss ovirt-engine-jboss-as >= 7.1.1 Line 79: Line 80: # all-in-one can't work on el6 due to missing ovirt-host-deploy-offline Line 81: # and missing vdsm > vdsm is the important part :) Done Line 82: %global with_aio 0 Line 83: Line 84: # emulate fedora java for simplicity Line 85: %undefine add_maven_depmap Line 602: Line 603: %description setup-plugin-allinone Line 604: All-in-one plugin for %{ovirt_product_name_short}'s setup Line 605: %endif Line 606: > why extra space? Done Line 607: Line 608: %prep Line 609: %setup -c -q Line 610: %if ! %{with_aio} Line 608: %prep Line 609: %setup -c -q Line 610: %if ! %{with_aio} Line 611: rm -rf packaging/firewalld/aio Line 612: %endif > please remove from DESTDIR not from source Done Line 613: Line 614: %build Line 615: make %{make_common_opts} Line 616: -- To view, visit https://gerrit.ovirt.org/40162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eb369dd83dd0002a74dc74b37a91e4a6f02ad6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronheim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
