anmolbabu has posted comments on this change. Change subject: engine, webadmin: Check volume emptyness for geo-rep ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40153/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java: Line 95: > please format Done Line 92: eligibilityPredicates.put(GlusterGeoRepNonEligibilityReason.SLAVE_VOLUME_TO_BE_EMPTY, new Predicate<GlusterVolumeEntity>() { Line 93: @Override Line 94: public boolean eval(GlusterVolumeEntity slaveVolume) { Line 95: VDSReturnValue returnValue = Backend.getInstance().getResourceManager().RunVdsCommand(VDSCommandType.CheckEmptyGlusterVolume, new GlusterVolumeVDSParameters(ClusterUtils.getInstance().getRandomUpServer(slaveVolume.getClusterId()).getId(), slaveVolume.getName())); Line 96: if(!returnValue.getSucceeded()) { > What is upServer is null? Do you want to handle that separately? Or move th oh yes I missed this. So, I was thinking of just removing such a volume from the list as it is just a criteria to obtain the list of eligible volumes. Line 97: return false; Line 98: } Line 99: return (boolean)returnValue.getReturnValue(); Line 100: } -- To view, visit https://gerrit.ovirt.org/40153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia86df17975069d4fe7c1740bf609597fde7b08ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
