Alon Bar-Lev has posted comments on this change. Change subject: manage domains: convert to new parameters parser ......................................................................
Patch Set 6: (2 comments) I do not exactly follow, do we support boolean parameters now? no --xxx -> false (default) with --xxx -> true https://gerrit.ovirt.org/#/c/39972/6/backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties File backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties: Line 1: module.help.usage = @PROGRAM_NAME@ [options] <action> [<args>] Line 2: module.help.header = \ Line 3: Available actions:\ missing \n? Line 4: add add a domain using specified provider and user\n\ Line 5: edit edit an existing domain\n\ Line 6: delete delete an existing domain\n\ Line 7: validate validate the current configuration\n\ Line 24: module.help.footer = \ Line 25: If you need custom logging setup, please create your own java.util.logging properties file,\n\ Line 26: set a path to this file into OVIRT_LOGGING_PROPERTIES environment variable and execute engine-manage-domains. Line 27: module.arg.help.name = help Line 28: module.arg.help.help = show manage domains help show help in all of these should be sufficient. Line 29: module.arg.version.name = version Line 30: module.arg.version.help = show manage domains version Line 31: module.arg.log-file.name = log-file Line 32: module.arg.log-file.help = Sets file to write logging into (if not set nothing is logged). -- To view, visit https://gerrit.ovirt.org/39972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
