Martin Betak has posted comments on this change. Change subject: core: added support for iothreads ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/39961/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1810: HotPlugCpuSupported, Line 1811: Line 1812: @TypeConverterAttribute(Boolean.class) Line 1813: @DefaultValueAttribute("false") Line 1814: IoThreadsSupported, isn't it better and more future compatible to put default "true" and in 0000_config.sql use the fn_db_add_config_value_for_versions_up_to('IoThreadsSupported', 'false', '3.5'); Line 1815: Line 1816: @TypeConverterAttribute(Map.class) Line 1817: @DefaultValueAttribute("{\"x86_64\":\"false\",\"ppc64\":\"false\"}") Line 1818: HotUnplugCpuSupported, -- To view, visit https://gerrit.ovirt.org/39961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32963f241b377f7fddb06e2b6b6492ebee2de207 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
