Alon Bar-Lev has posted comments on this change. Change subject: manage domains: convert to new parameters parser ......................................................................
Patch Set 4: (3 comments) minor comments. great, I guess we are waiting for the boolean no_option. also, please reorder patches, so that the new cli will be part of this one and this patch will be first. https://gerrit.ovirt.org/#/c/39972/4/backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties File backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties: Line 1: module.help.usage = @PROGRAM_NAME@ [options] <action> [<args>] Line 2: module.help.header = \ Line 3: Available actions:\ Line 4: \n add add a domain using specified provider and user\ usually best to have \n at end of line... :) Line 5: \n edit edit an existing domain\ Line 6: \n delete delete an existing domain\ Line 7: \n validate validate the current configuration\ Line 8: \n list list the current configuration\ Line 145: validate.help.footer = \ Line 146: Example:\n\ Line 147: \t@PROGRAM_NAME@ validate [--report] [--config-file=CFG_FILE] Line 148: list.arg.help.name = help Line 149: list.arg.help.help = Show help for list action show help should be sufficient Line 150: list.arg.config-file.name= config-file Line 151: list.arg.config-file.help = Use the given alternate configuration file Line 152: list.arg.config-file.type = has_argument Line 153: list.arg.config-file.default = @ENGINE_ETC@/engine-manage-domains/engine-manage-domains.conf Line 146: Example:\n\ Line 147: \t@PROGRAM_NAME@ validate [--report] [--config-file=CFG_FILE] Line 148: list.arg.help.name = help Line 149: list.arg.help.help = Show help for list action Line 150: list.arg.config-file.name= config-file space Line 151: list.arg.config-file.help = Use the given alternate configuration file Line 152: list.arg.config-file.type = has_argument Line 153: list.arg.config-file.default = @ENGINE_ETC@/engine-manage-domains/engine-manage-domains.conf Line 154: list.help.header = List the current configuration -- To view, visit https://gerrit.ovirt.org/39972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
