anmolbabu has posted comments on this change. Change subject: gluster: Modified to disable the new snapshot creation ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40118/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 579: getNewGeoRepSessionCommand().setIsExecutionAllowed(allowCreateGeoRepSession); Line 580: } Line 581: Line 582: private boolean isCreateSnapshotAvailable(List<GlusterVolumeEntity> list) { Line 583: if (list.size() == 1) { may be we could avoid this in a subsequent refactoring patch. This is a repetitive check although not expensive(here and also in updateActionAvailability). Probably within if (list.size() == 1) of updateActionAvailability you could invoke isCreateSnapshotAvailable and hence avoid checking list size again here anyway the flag(in updateActionAvailability) defaults to false if not touched. May not be in this patch because this line is not edited here. Line 584: List<GlusterBrickEntity> bricks = list.get(0).getBricks(); Line 585: for (GlusterBrickEntity brick : bricks) { Line 586: if (brick.getStatus() != GlusterStatus.UP) { Line 587: return false; -- To view, visit https://gerrit.ovirt.org/40118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ed296a6afc4dfa5f3e7023c0dc40b7da4ad4392 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
