Martin Mucha has posted comments on this change. Change subject: core: Introduce BusinessEntityMap ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/33329/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMap.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMap.java: Line 5: import java.util.Map; Line 6: Line 7: import org.ovirt.engine.core.compat.Guid; Line 8: Line 9: public class BusinessEntityMap<E extends BusinessEntity<Guid> & Nameable> { > Please add java doc to this class. Done Line 10: private Map<String, E> entitiesByName; Line 11: private Map<Guid, E> entitiesById; Line 12: Line 13: // added for the sake of checkstyle rule -- To view, visit https://gerrit.ovirt.org/33329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4540f813f8a787a38ba3e692b6ddd3fcc6be536a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
