Moti Asayag has posted comments on this change. Change subject: core: using JPA for engine backup awareness ......................................................................
Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40091/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java: Line 38: if (this == obj) Line 39: return true; Line 40: if (obj == null) Line 41: return false; Line 42: if (obj.getClass() != this.getClass()) { Liran, Yevgeny, now that we're using hibernate and it creates a proxy for the entities, is there a need to enforce in the equals impl of methods "is instance of" or can we settle for getClass() comparison ? Line 43: return false; Line 44: } Line 45: EngineBackupLog other = (EngineBackupLog)obj; Line 46: return (dbName.equals(other.getDbName()) && doneAt.equals(other.getDoneAt())); -- To view, visit https://gerrit.ovirt.org/40091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0aa9c4d0c8c0a5f7b40a022d7670f30c5fd5b77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Anonymous Coward #1000793 Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
