Alon Bar-Lev has posted comments on this change. Change subject: manage domains: convert to new parameters parser ......................................................................
Patch Set 2: (1 comment) missing properties file I guess. missing removal of the existing parser. will continue soon. https://gerrit.ovirt.org/#/c/39972/2/packaging/bin/engine-manage-domains.sh File packaging/bin/engine-manage-domains.sh: Line 23: Line 24: exec "${JAVA_HOME}/bin/java" \ Line 25: -Djava.util.logging.config.file="${OVIRT_LOGGING_PROPERTIES}" \ Line 26: -Djboss.modules.write-indexes=false \ Line 27: -Dorg.ovirt.engine.exttool.core.programName=${0} \ we should also quote this. Line 28: -Dorg.ovirt.engine.exttool.core.packageName="${PACKAGE_NAME}" \ Line 29: -Dorg.ovirt.engine.exttool.core.packageVersion="${PACKAGE_VERSION}" \ Line 30: -Dorg.ovirt.engine.exttool.core.packageDisplayName="${PACKAGE_DISPLAY_NAME}" \ Line 31: -Dorg.ovirt.engine.exttool.core.engineEtc="${ENGINE_ETC}" \ -- To view, visit https://gerrit.ovirt.org/39972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
