Daniel Erez has posted comments on this change. Change subject: core: Validate if Cinder Storage Domain contain disks on detach ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40016/5/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1408: external shouldn't the message be specific to volume providers? i.e. why should it be generic? (as only Cinder domains can be attached to a dc...) -- To view, visit https://gerrit.ovirt.org/40016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I501351c2505a50d083db64e59ed2dd7201649901 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
