Liron Aravot has posted comments on this change.
Change subject: core: change vdsSpmId related command to support numerous vdss
......................................................................
Patch Set 11: (4 inline comments)
answered amureini comments
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsSpmIdParameters.java
Line 6: import org.ovirt.engine.core.compat.Guid;
Line 7:
Line 8: public class VdsSpmIdParameters extends VdsActionParameters {
Line 9:
Line 10: private static final long serialVersionUID = 1L;
Done
Line 11: private List<VdsStatic> vdss;
Line 12: Guid storagePoolId;
Line 13:
Line 14: public Guid getStoragePoolId() {
Line 7:
Line 8: public class VdsSpmIdParameters extends VdsActionParameters {
Line 9:
Line 10: private static final long serialVersionUID = 1L;
Line 11: private List<VdsStatic> vdss;
all of our daos returns lists.. and to be able to use
Collections.singletonList() :-)
Line 12: Guid storagePoolId;
Line 13:
Line 14: public Guid getStoragePoolId() {
Line 15: return storagePoolId;
Line 8: public class VdsSpmIdParameters extends VdsActionParameters {
Line 9:
Line 10: private static final long serialVersionUID = 1L;
Line 11: private List<VdsStatic> vdss;
Line 12: Guid storagePoolId;
Done
Line 13:
Line 14: public Guid getStoragePoolId() {
Line 15: return storagePoolId;
Line 16: }
Line 27: this.vdss = vdss;
Line 28: }
Line 29:
Line 30: public VdsSpmIdParameters(List<VdsStatic> vdss, Guid
storagePoolId) {
Line 31: super(null);
all of the vds command use parameters classes from that hierarchy and we can
use it to add needed logic/methods to all of them. i think that we should
consider to change the vds in the hirerchy to list of vdss so we would be able
to acquire less locks and would be able to avoid races when performing the same
operation on number of hosts rather than add external lock all over.
Line 32: setVdss(vdss);
Line 33: setStoragePoolId(storagePoolId);
Line 34: }
Line 35:
--
To view, visit http://gerrit.ovirt.org/8277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7531b9edb763d32b96c58104385349d587de3416
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
