Arik Hadas has posted comments on this change. Change subject: engine: Remove from host_device table the ids of vms which are down ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39894/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java: Line 62: hostDeviceDao.setVmIdOnHostDevice(hostDevice.getId(), null); Line 63: } Line 64: } Line 65: } Line 66: } it could be nice to have a storaged-procedure that does it, should be simpler code. However, if keeping it that way and all you need is the status, can query just VmDynamic instead -- To view, visit https://gerrit.ovirt.org/39894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728fadd7d9d4c10f905866353e07912cc55d1c9e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
