Allon Mureinik has posted comments on this change. Change subject: core: ordering getAllFromVms ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/dbscripts/vms_sp.sql Line 531: RETURN QUERY SELECT DISTINCT vms.* Line 532: FROM vms Line 533: WHERE (NOT v_is_filtered OR EXISTS (SELECT 1 Line 534: FROM user_vm_permissions_view Line 535: WHERE user_id = v_user_id AND entity_id = vm_guid)) order by vm_guid; Please move this a line down and capitalize the ODER BY to keep the code readable. Line 536: Line 537: END; $procedure$ Line 538: LANGUAGE plpgsql; Line 539: -- To view, visit http://gerrit.ovirt.org/8274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5958e870d3315316a59e1038101b2511bd8811 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
