Arik Hadas has posted comments on this change. Change subject: webadmin: initialize import parameters in one place ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40057/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java: Line 701: getClusterQuota().getIsAvailable()) { Line 702: prm.setQuotaId(getClusterQuota().getSelectedItem().getId()); Line 703: } Line 704: Line 705: CpuProfile cpuProfile = getCpuProfiles().getSelectedItem(); > ok, but now also the VmListModel have inherited this logic. I can imagine i I added it to VmListModel (9582adf4) so I can explain: the problem was that VmListModel didn't have cpu-profiles and I didn't want to add it there because I knew it will not stay there (I treated it as a temporary code, there's also such comment there as an evidence :) ).. Line 706: if (cpuProfile != null) { Line 707: prm.setCpuProfileId(cpuProfile.getId()); Line 708: } Line 709: -- To view, visit https://gerrit.ovirt.org/40057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8725ffb9eb58b1c081de593808802a7363d7db73 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
