Eli Mesika has posted comments on this change. Change subject: engine: Enhance brick to support storage network ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40046/3/packaging/dbscripts/upgrade/03_05_1410_add_network_gluster_bricks.sql File packaging/dbscripts/upgrade/03_05_1410_add_network_gluster_bricks.sql: Line 1: select fn_db_add_column('gluster_volume_bricks', 'network_id', 'uuid NULL'); Line 2: Line 3: SELECT fn_db_create_constraint('gluster_volume_bricks', 'fk_gluster_volume_bricks_network_id', 'FOREIGN KEY (network_id) REFERENCES network(id) ON DELETE NO ACTION'); RESTRICT prevents deletion of a referenced row. NO ACTION means that if any referencing rows still exist when the constraint is checked, an error is raised; this is the default behavior if you do not specify anything. (The essential difference between these two choices is that NO ACTION allows the check to be deferred until later in the transaction, whereas RESTRICT does not.) So I clearly prefer CASCADE or RESTRICT -- To view, visit https://gerrit.ovirt.org/40046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9749febf721172a09ddce756c0eeb745a9502e1a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
