Liran Zelkha has posted comments on this change. Change subject: core: Add JPA Java infrastructure ......................................................................
Patch Set 69: (3 comments) https://gerrit.ovirt.org/#/c/33835/69/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/AbstractJpaDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/AbstractJpaDao.java: Line 75: /** Line 76: * Runs the query and detaches its results. Line 77: * Line 78: * @param query Line 79: * the <code>TypedQuery</code> to be run. > my intention was to leave the {@link TypeQuery} as is and instead replace i Done Line 80: * @return the result <code>List</code> of the detached entities. Line 81: */ Line 82: protected List<T> multipleResults(TypedQuery<T> query) { Line 83: final List<T> resultList = query.getResultList(); Line 92: /** Line 93: * Runs the query, expect a single result to be returned Line 94: * Line 95: * @param query Line 96: * the <code>TypedQuery</code> to be run > same, please restore the {@code TypedQuery} Done Line 97: * @return A single object result of the given query. Detached state. Returns <code>null</code> in case of query Line 98: * does not return any result. Line 99: */ Line 100: protected T singleResult(TypedQuery<T> query) { Line 93: * Runs the query, expect a single result to be returned Line 94: * Line 95: * @param query Line 96: * the <code>TypedQuery</code> to be run Line 97: * @return A single object result of the given query. Detached state. Returns <code>null</code> in case of query > replace <code>null</code> with {@code null} Done Line 98: * does not return any result. Line 99: */ Line 100: protected T singleResult(TypedQuery<T> query) { Line 101: try { -- To view, visit https://gerrit.ovirt.org/33835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide82bf8cc647426e37dc42a113867c52699c3f0b Gerrit-PatchSet: 69 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
