Liron Aravot has uploaded a new change for review.
Change subject: core: disable selection of new vds_spm_id withing the same DC
......................................................................
core: disable selection of new vds_spm_id withing the same DC
when changing host cluster to another cluster that is under the same DC,
there is no need to select a new vds_spm_id for that host.
Change-Id: I7698ee424949ab6c0960ef7428b162930ae10856
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/8287/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
index 81d7c54..d747e76 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
@@ -112,7 +112,8 @@
return;
}
- if (targetStoragePool != null) {
+ if (targetStoragePool != null
+ &&
!targetStoragePool.getId().getValue().equals(getSourceCluster().getstorage_pool_id()))
{
VdcReturnValueBase addVdsSpmIdReturn =
Backend.getInstance().runInternalAction(VdcActionType.AddVdsSpmId,
getParameters(),
@@ -153,7 +154,8 @@
// handle spm
getParameters().setCompensationEnabled(true);
getParameters().setTransactionScopeOption(TransactionScopeOption.RequiresNew);
- if (getSourceCluster().getstorage_pool_id() != null) {
+ if (getSourceCluster().getstorage_pool_id() != null
+ &&
!getSourceCluster().getstorage_pool_id().equals(targetStoragePool.getId().getValue()))
{
VdcReturnValueBase removeVdsSpmIdReturn =
Backend.getInstance().runInternalAction(VdcActionType.RemoveVdsSpmId,
getParameters(),
--
To view, visit http://gerrit.ovirt.org/8287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7698ee424949ab6c0960ef7428b162930ae10856
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
