Alon Bar-Lev has posted comments on this change.

Change subject: packaging: rollback database if only pki upgrade took place
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 551: 
Line 552:     JKSKEYSTORE = "/etc/pki/ovirt-engine/.keystore"
Line 553:     TMPAPACHECONF = basedefs.FILE_HTTPD_SSL_CONFIG + ".tmp"
Line 554: 
Line 555:     def mayUpdateDB(self):
Yes. If it does no exist it is post migration.
Line 556:         return os.path.exists(self.JKSKEYSTORE)
Line 557: 
Line 558:     def prepare(self):
Line 559:         if os.path.exists(self.JKSKEYSTORE):


Line 848:         print MSG_ERROR_NO_ROLLBACK_AVAIL
Line 849:         print MSG_ERROR_CHECK_LOG%(LOG_FILE)
Line 850:         sys.exit(2)
Line 851: 
Line 852:     updateRelatedToDB = isUpdateRelatedToDb(rhyum) or ca.mayUpdateDB()
Done
Line 853: 
Line 854:     # No rollback in this case
Line 855:     try:
Line 856:         # We ask the user before stoping ovirt-engine or take command 
line option


--
To view, visit http://gerrit.ovirt.org/8276
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1f7ee7d0136922ca929f755f326acda77bbb7e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to