Eli Mesika has posted comments on this change.

Change subject: core: Vm Icons - backend part
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/38600/15/packaging/dbscripts/vm_icons_sp.sql
File packaging/dbscripts/vm_icons_sp.sql:

Line 42: 
Line 43: --Update{0}
Line 44: Create or replace FUNCTION UpdateVmIcon(
Line 45:     v_id UUID,
Line 46:     v_data_url VARCHAR(32768)) -- 1024 * 32
> please change to text
If this is a fixed size always , then the right datatype should be char (not 
varchar)
Line 47:     RETURNS VOID
Line 48: AS $procedure$
Line 49: BEGIN
Line 50:     UPDATE vm_icons


-- 
To view, visit https://gerrit.ovirt.org/38600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98ad0d76285af3b2913e477a340bfd1ac09a296e
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to