Ayal Baron has posted comments on this change.
Change subject: webadmin: select last snapshot by default (#851094)
......................................................................
Patch Set 1: (7 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
Line 68: initNicsTable();
Line 69: initAppsTable();
Line 70:
Line 71: // Add Tabs
Line 72: add(new ScrollPanel(generalForm), constants.generalLabel());
is this to support more snapshots than are viewable? i.e. is not related to the
selection issue?
Line 73: add(new ScrollPanel(disksTable), constants.disksLabel());
Line 74: add(new ScrollPanel(nicsTable), constants.nicsLabel());
Line 75: add(new ScrollPanel(appsTable), constants.applicationsLabel());
Line 76:
Line 79: @SuppressWarnings("unchecked")
Line 80: @Override
Line 81: public void eventRaised(Event ev, Object sender, EventArgs
args) {
Line 82: Snapshot snapshot = (Snapshot)
vmSnapshotListModel.getSelectedItem();
Line 83: // updatePanel(snapshot);
why keep the line?
Line 84: }
Line 85: });
Line 86: }
Line 87:
Line 128: public String getValue(DiskImage object) {
Line 129: return object.getDiskAlias();
Line 130: }
Line 131: };
Line 132: disksTable.addColumn(aliasColumn, constants.aliasDisk());
this is to change the column name from 'Name' to 'Alias'? i.e., again, has
nothing to do with the selection issue?
Line 133:
Line 134: DiskSizeColumn<DiskImage> sizeColumn = new
DiskSizeColumn<DiskImage>() {
Line 135: @Override
Line 136: protected Long getRawValue(DiskImage object) {
Line 152: protected VolumeType getRawValue(DiskImage object) {
Line 153: return
VolumeType.forValue(object.getvolume_type().getValue());
Line 154: }
Line 155: };
Line 156: disksTable.addColumn(allocationColumn,
constants.allocationDisk(), "60px"); //$NON-NLS-1$
beatification? or due to changing panel type to ScrollPanel? or to addition of
description column below?
Line 157:
Line 158: TextColumnWithTooltip<DiskImage> interfaceColumn = new
TextColumnWithTooltip<DiskImage>() {
Line 159: @Override
Line 160: public String getValue(DiskImage object) {
Line 178: }
Line 179: };
Line 180: disksTable.addColumn(dateCreatedColumn,
constants.creationDateDisk(), "80px"); //$NON-NLS-1$
Line 181:
Line 182: TextColumnWithTooltip<DiskImage> descriptionColumn = new
TextColumnWithTooltip<DiskImage>() {
this is yet another unrelated change?
Line 183: @Override
Line 184: public String getValue(DiskImage object) {
Line 185: return object.getDiskDescription();
Line 186: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
Line 274: if ((snapshot.getType() == SnapshotType.ACTIVE &&
getInType(SnapshotType.PREVIEW, snapshots) == null)
Line 275: || snapshot.getType() == SnapshotType.PREVIEW) {
Line 276: sortedSnapshots.add(0, snapshot);
Line 277: }
Line 278: else if (snapshot.getType() == SnapshotType.REGULAR ||
snapshot.getType() == SnapshotType.STATELESS) {
not relevant to current patch, but if a new 'type' of snapshot is added to the
enum then current code would silently ignore it (instead of either throwing an
error or dealing with it in a default *visible* manner)
Line 279: sortedSnapshots.add(snapshot);
Line 280: }
Line 281: }
Line 282:
Line 304: super.OnEntityChanged();
Line 305:
Line 306: if (getEntity() != null)
Line 307: {
Line 308: isEntityChanged = true;
does this mean that unselecting the snapshot (ctrl + select current selection)
doesn't clear the info? (assuming one can unselect to begin with)
Line 309: getSearchCommand().Execute();
Line 310: }
Line 311: }
Line 312:
--
To view, visit http://gerrit.ovirt.org/8260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09884a06615ecd2c1fdf7128f7af684a7e70a7d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
