Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use yum API
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 224: # Call xpathEval to strip the metadata string from the top of
the new xml node
Line 225: parentNode.addChild(newNode.xpathEval('/*')[0])
Line 226:
Line 227:
Line 228: class MiniYumSink(object):
Done
Line 229:
Line 230: def _currentfds(self):
Line 231: fds = []
Line 232: try:
Line 269: save = self._currentfds()
Line 270: for i in range(3):
Line 271: os.dup2(self._fds[i], i)
Line 272: print output_messages.WARN_INSTALL_GPG_KEY % (userid,
hexkeyid)
Line 273: ret = askYesNo(INFO_Q_PROCEED)
No... this only applies if new gnupg key is to be accepted.
I don't think we should update documentation, maybe add note that if new key is
to be accepted a question will be prompted?
This is similar to yum processing (without -y).
Line 274: for i in range(3):
Line 275: os.dup2(save[i], i)
Line 276: return ret
Line 277:
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 545:
Line 546: return False
Line 547:
Line 548: def main(options):
Line 549: # BEGIN: PROCESS-INITIALIZATION
Oh.... I am a machine... :)
Line 550: miniyumsink = utils.MiniYumSink()
Line 551: MiniYum.setup_log_hook(sink=miniyumsink)
Line 552: extraLog = open(LOG_FILE, "a")
Line 553: miniyum = MiniYum(sink=miniyumsink, extraLog=extraLog)
....................................................
File packaging/fedora/setup/output_messages.py
Line 186: INFO_STRING_EXCEEDS_MAX_LENGTH="String length exceeds the maximum
length allowed: %s"
Line 187: INFO_STRING_CONTAINS_ILLEGAL_CHARS="String contains illegal
characters"
Line 188:
Line 189: # Yum
Line 190: WARN_INSTALL_GPG_KEY = "\nApprove installing GPG key userid=%s
hexkeyid=%s"
I will gladly accept any other phrase :)
Modified a bit.
What do you mean documentation? where? we?
Line 191:
Line 192: #####################
Line 193: #####ERR MESSAGES####
Line 194: #####################
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 745: %{engine_data}/scripts/setup_params.py*
Line 746: %{engine_data}/scripts/setup_sequences.py*
Line 747: %{engine_data}/scripts/setup_controller.py*
Line 748: %{engine_data}/scripts/common_utils.py*
Line 749: %{engine_data}/scripts/miniyum.py*
Done
Line 750: %{engine_data}/scripts/output_messages.py*
Line 751: %{engine_data}/scripts/nfsutils.py*
Line 752: %{engine_data}/scripts/engine-setup.py*
Line 753: %{engine_data}/scripts/engine-cleanup.py*
--
To view, visit http://gerrit.ovirt.org/8221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01c0c10c3bca42770bf05222c8b2b82b01fee0a6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
