Maor Lipchuk has posted comments on this change. Change subject: core: update CinderDisks connections on RunVm ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39656/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java: Line 283: try { Line 284: CinderBroker cinderBroker = new CinderBroker(cinderDisk.getStorageIds().get(0), getReturnValue().getExecuteFailedMessages()); Line 285: CinderConnectionInfo connectionInfo = cinderBroker.initializeConnectionForDisk(cinderDisk); Line 286: CinderVolumeDriver cinderVolumeDriver = CinderVolumeDriver.forValue(connectionInfo.getDriverVolumeType()); Line 287: if (cinderVolumeDriver == null) { I don't understand this. Why do you need here cinderVolumeDrive? you don't use it instead of just checking its existence Line 288: addCustomValue("DiskAlias", cinderDisk.getDiskAlias()); Line 289: auditLogDirector.log(this, AuditLogType.CINDER_DISK_CONNECTION_VOLUME_DRIVER_UNSUPPORTED); Line 290: return false; Line 291: } -- To view, visit https://gerrit.ovirt.org/39656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie48e01acd6c3afcbc322603e0358b63e2b2bdf99 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
