Juan Hernandez has posted comments on this change. Change subject: packaging: cleanup: sync log file global variable in setup and upgrade ......................................................................
Patch Set 1: All upper case names are for constants, and this is not as far as I can tell. The rest of the changes in the patch are ok. -- To view, visit http://gerrit.ovirt.org/8266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04fedb7460ec9ecc1959ff56da67300406fd1b77 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
