Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VMCommand
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 362: getActionType().getActionGroup()));
Line 363: return permissionList;
Line 364: }
Line 365:
Line 366: protected int getBlockSparseInitSizeInGb() {
Not sure about this one - GB is a recognized shorthand for gigabyte.
Line 367: return Config.<Integer>
GetValue(ConfigValues.InitStorageSparseSizeInGB).intValue();
Line 368: }
Line 369:
Line 370: protected List<ValidationError> validateCustomProperties(VmStatic
vmStaticFromParams) {
Line 458: /**
Line 459: * The following method should check if os of guest is supported
for hot plug/unplug operation
Line 460: * @return
Line 461: */
Line 462: protected boolean isOsSupportingHotPlug() {
Here too - OS is short for Operating System - not sure camlecasing it will make
the code more readable.
Line 463: String vmOs = getVm().getos().name();
Line 464: String[] unsupportedOSs = Config.<String>
GetValue(ConfigValues.HotPlugUnsupportedOsList).split(",");
Line 465: for (String os : unsupportedOSs) {
Line 466: if (os.equalsIgnoreCase(vmOs)) {
--
To view, visit http://gerrit.ovirt.org/8263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6750a6bf6bac763a73f5e7eb9912acf7bd0c50e0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
