Kanagaraj M has posted comments on this change. Change subject: webadmin : Fix bug 1184384 ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/39743/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-04-10 11:59:31 +0530 Line 4: Commit: anmolbabu <[email protected]> Line 5: CommitDate: 2015-04-13 07:27:35 -0400 Line 6: Line 7: webadmin : Fix bug 1184384 Use a short header instead of bug no Line 8: Line 9: In GlusterOnly-Mode, in cluster dialog, Line 10: the following make no sense Line 11: 1. Enable to set vm maintenance reason Line 6: Line 7: webadmin : Fix bug 1184384 Line 8: Line 9: In GlusterOnly-Mode, in cluster dialog, Line 10: the following make no sense the following are not applicable Line 11: 1. Enable to set vm maintenance reason Line 12: 2. /dev/random/ source Line 13: 3. /dev/hwrng/source Line 14: Hence this patch sets them invisible in https://gerrit.ovirt.org/#/c/39743/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 871: setComment(new EntityModel<String>()); Line 872: setEnableTrustedService(new EntityModel<Boolean>(false)); Line 873: setEnableHaReservation(new EntityModel<Boolean>(false)); Line 874: setEnableOptionalReason(new EntityModel<Boolean>(false)); Line 875: getEnableOptionalReason().setIsAvailable(ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly); getEnableOptionalReason().setIsAvailable(ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly)) Line 876: setEnableHostMaintenanceReason(new EntityModel<Boolean>(false)); Line 877: setAllowClusterWithVirtGlusterEnabled(true); Line 878: AsyncDataProvider.getInstance().getAllowClusterWithVirtGlusterEnabled(new AsyncQuery(this, new INewAsyncCallback() { Line 879: @Override https://gerrit.ovirt.org/#/c/39743/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java: Line 433: setVisibilities(); Line 434: } Line 435: Line 436: private void setVisibilities() { Line 437: rngLabel.setVisible(ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly); same here Line 438: } Line 439: Line 440: @Override Line 441: protected void populateTabMap() { -- To view, visit https://gerrit.ovirt.org/39743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8f2e65b16f4dbf00f76da814a87d4131ebab6b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
