Piotr Kliczewski has posted comments on this change. Change subject: engine : Add force case to removebrick in JsonRpcVdsServer ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39744/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1113: int replicaCount, Line 1114: Boolean forceRemove) { Line 1115: // forceRemove not used in gluster API Line 1116: RequestBuilder rBuilder; Line 1117: if(forceRemove) { What about String commandName = null; if (forceRemove) { commandName = "GlusterVolume.removeBrickForce"; else { commandName = "GlusterVolume.removeBrickStart"; } JsonRpcRequest request = new RequestBuilder(commandName).with ? Line 1118: rBuilder = new RequestBuilder("GlusterVolume.removeBrickForce"); Line 1119: } else { Line 1120: rBuilder = new RequestBuilder("GlusterVolume.removeBrickStart"); Line 1121: } -- To view, visit https://gerrit.ovirt.org/39744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b4a681f8fc7d62d40874078dd9d86b5a85d068e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
