Ramesh N has uploaded a new change for review. Change subject: gluster: fix NPE in gluster sync job for volume capacity info ......................................................................
gluster: fix NPE in gluster sync job for volume capacity info Fix NPE in GlusterSyncJob.refreshVolumeDetails. When brick goes down, volumeAdvancedDetails are not available. So adding a Null check for volumeAdvancedDetails. Change-Id: Iab4c5cdc38c53aa7b35417ad3db10b1cb4ac0f2a Bug-Url: https://bugzilla.redhat.com/1212290 Signed-off-by: Ramesh Nachimuthu <rnach...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/39968/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java index 5bced3d..2fab6a6 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java @@ -944,7 +944,7 @@ GlusterVolumeAdvancedDetails volumeAdvancedDetails = getVolumeAdvancedDetails(upServer, volume.getClusterId(), volume.getName()); - if (volumeAdvancedDetails.getCapacityInfo() != null) { + if (volumeAdvancedDetails != null && volumeAdvancedDetails.getCapacityInfo() != null) { if (volume.getAdvancedDetails().getCapacityInfo() == null) { getVolumeDao().addVolumeCapacityInfo(volumeAdvancedDetails.getCapacityInfo()); } else { -- To view, visit https://gerrit.ovirt.org/39968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab4c5cdc38c53aa7b35417ad3db10b1cb4ac0f2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
