Roy Golan has posted comments on this change. Change subject: engine: scheduling host- find free VF ......................................................................
Patch Set 14: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/37931/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 256: List<Guid> hostWhiteList, Line 257: Guid destHostId, Line 258: List<String> messages, Line 259: VdsFreeMemoryChecker memoryChecker, Line 260: Map<Guid, String> passthroughVnicToVfMap, couldn't see how this is related to the schedule api. that's a total violation of it. Line 261: String correlationId) { Line 262: clusterLockMap.putIfAbsent(cluster.getId(), new Semaphore(1)); Line 263: try { Line 264: log.debug("Scheduling started, correlation Id: {}", correlationId); Line 297: vm.getMinAllocatedMem(), Line 298: 0, Line 299: 0); Line 300: Line 301: if (passthroughVnicToVfMap != null && bestHost != null && hostToVnicToVfMap.containsKey(bestHost)) { the output of the schedule api is a host. use it in your client code, which is the RunVm, to update your VdsConfigHelper which you injected the instance into I think Line 302: passthroughVnicToVfMap.putAll(hostToVnicToVfMap.get(bestHost)); Line 303: markVfsAsUsedByVm(bestHost, vm.getId(), passthroughVnicToVfMap); Line 304: } Line 305: -- To view, visit https://gerrit.ovirt.org/37931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58c7aaa7a5a7160132418c397840583209aa8371 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
