Eli Mesika has posted comments on this change. Change subject: core: Fix db upgrage scripts numbering check ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39947/1/build/dbscripts-duplicate_upgrade_scripts.sh File build/dbscripts-duplicate_upgrade_scripts.sh: Line 1: #!/bin/sh Line 2: Line 3: OUT="$(find "$(dirname "$0")/../packaging/dbscripts" -exec basename {} \; | grep -P '^\d{2}_\d{2}_\d{2,8}' -o | sort | uniq -d)" > Perhaps, instead of -exec basename, Used like that in other scripts as well , so I am for consistency Line 4: Line 5: if [ -n "${OUT}" ]; then Line 6: echo "Found duplicate upgrade scripts with version $(echo ${OUT}), please resolve and retry" >&2 Line 7: exit 1 -- To view, visit https://gerrit.ovirt.org/39947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e48052b4e65e9e1cccd8be82acf0b4bcd59f7c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
