Omer Frenkel has posted comments on this change. Change subject: core: VirtIO console access key management ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/39512/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java: Line 42: return result; Line 43: } Line 44: Line 45: @Override Line 46: public List<PermissionSubject> getPermissionCheckSubjects() { > I run this code before (v4: https://gerrit.ovirt.org/#/c/39512/4/backend/ma i assume you just used the super user who can do everything easily? :) i might be wrong but i think that other users would be blocked Line 47: return Collections.singletonList(new PermissionSubject(getUserId(), VdcObjectType.User, ActionGroup.MANIPULATE_USERS)); Line 48: } -- To view, visit https://gerrit.ovirt.org/39512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ff5403823e752e695ebde76a4b7fb83e07099b6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
