Kanagaraj M has posted comments on this change. Change subject: webadmin: fix action availability for create brick ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39820/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java: Line 220: boolean canCreateBrick = false; : for (StorageDevice device : getItems()) { : if (device.getCanCreateBrick()) { : canCreateBrick = true; : break; : } : } : : if (canCreateBrick) { : List<StorageDevice> selectedDevices = getSelectedItems(); : if (selectedDevices != null) { : for (StorageDevice device : selectedDevices) { : if(!device.getCanCreateBrick()){ : canCreateBrick = false; : break; : } : } : } : } Order of the above logic should be swapped. You need to look for the selectedDevices first. If no devices selected, then look for all the devices. -- To view, visit https://gerrit.ovirt.org/39820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecaff8f5863bd3107ba109e6f1f9d695d8ee67aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
