Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/37886/21/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java: Line 31: private static final org.slf4j.Logger logger = LoggerFactory.getLogger(ExtensionsToolExecutor.class); Line 32: Line 33: public static void main(String[] args) { Line 34: int exitStatus = 1; Line 35: try { > I couldn't find any env varibale for log level. Should I create some common OVIRT_LOGGING_LEVEL will be nice :) you can access it via System.getenv() default: INFO Line 36: ParametersParser parser; Line 37: try (InputStream stream = ExtensionsToolExecutor.class.getResourceAsStream("arguments.properties")) { Line 38: parser = new ParametersParser(stream, "core"); Line 39: } -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
