Maor Lipchuk has posted comments on this change. Change subject: core: introduce CloneCinderDisksCommand ......................................................................
Patch Set 2: (2 comments) minor log comment https://gerrit.ovirt.org/#/c/39644/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java: Line 65: Line 66: private ImagesContainterParametersBase buildChildCommandParameters(CinderDisk cinderDisk) { Line 67: ImagesContainterParametersBase createParams = new ImagesContainterParametersBase(cinderDisk.getId()); Line 68: DiskImage templateDisk = getParameters().getDisksMap().get(cinderDisk.getId()); Line 69: cinderDisk.setDiskAlias(templateDisk.getDiskAlias()); It will be more right to get the alias from the parameters, but I guess you've done that to be compatible of how we are creating a VM today from a Template Line 70: createParams.setStorageDomainId(templateDisk.getStorageIds().get(0)); Line 71: createParams.setEntityInfo(getParameters().getEntityInfo()); Line 72: return withRootCommandInfo(createParams, getParameters().getParentCommand()); Line 73: } https://gerrit.ovirt.org/#/c/39644/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java: Line 24: return; Line 25: case FAILED: Line 26: case FAILED_RESTARTED: Line 27: case UNKNOWN: Line 28: anyFailed = true; Please a a warn log here, so we can know there was a failure for the specific child command and the command status Line 29: break; Line 30: default: Line 31: break; Line 32: } -- To view, visit https://gerrit.ovirt.org/39644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b2e4b8c3f5a999303e45e8431809a276835c8ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
