anmolbabu has posted comments on this change. Change subject: engine: Fix unknown session status ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39869/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java: Line 15: private static final String BYTES_PENDING = "bytesPending"; Line 16: private static final String DELETES_PENDING = "deletesPending"; Line 17: private static final String FILES_SKIPPED = "filesSkipped"; Line 18: Line 19: private final ArrayList<GlusterGeoRepSessionDetails> geoRepDetails = new ArrayList<GlusterGeoRepSessionDetails>(); > Where this value being used?. May be we can remove if we are not using. Done Line 20: private final List<GlusterGeoRepSession> geoRepSessions = new ArrayList<GlusterGeoRepSession>(); Line 21: Line 22: @Override Line 23: protected GlusterGeoRepSessionDetails getSessionDetails(Map<String, Object> innerMap) { Line 50: } Line 51: } Line 52: Line 53: public List<GlusterGeoRepSessionDetails> getGeoRepDetails() { Line 54: return super.getGeoRepSessions().get(0).getSessionDetails(); > Why are u returning only the sessionDetails of first session? We are invoking this per session basis. So sessions will effectively contain only 1 entry at this point Line 55: } Line 56: Line 57: @Override Line 58: public List<GlusterGeoRepSession> getGeoRepSessions() { -- To view, visit https://gerrit.ovirt.org/39869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299ecbf2d66dc990acff8db1def250f615cc6279 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
