Ravi Nori has uploaded a new change for review. Change subject: webadmin: Buttons on Hosts tab are not unified ......................................................................
webadmin: Buttons on Hosts tab are not unified On hosts tab enable/disable buttons instead of hiding them Change-Id: Ia6ff00bea3f65e8be6090b4408e57984bf67c2ad Bug-Url: https://bugzilla.redhat.com/1209876 Signed-off-by: Ravi Nori <rn...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/46/39846/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java index 449c1f1..7dc61c5 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java @@ -2055,7 +2055,6 @@ && (VdcActionUtils.canExecute(items, VDS.class, VdcActionType.ApproveVds) || (items.get(0) .getStatus() == VDSStatus.InstallFailed && items.get(0).getVdsType() == VDSType.oVirtNode)); getApproveCommand().setIsExecutionAllowed(approveAvailability); - getApproveCommand().setIsAvailable(approveAvailability); boolean installAvailability = false; if (items.size() == 1 && items.get(0) instanceof VDS) { @@ -2064,7 +2063,6 @@ host.getStatus() == VDSStatus.Maintenance; } getInstallCommand().setIsExecutionAllowed(installAvailability); - getInstallCommand().setIsAvailable(installAvailability); boolean upgradeAvailability = false; if (installAvailability) { @@ -2074,7 +2072,6 @@ } } getUpgradeCommand().setIsExecutionAllowed(upgradeAvailability); - getUpgradeCommand().setIsAvailable(upgradeAvailability); getMaintenanceCommand().setIsExecutionAllowed(items.size() > 0 && VdcActionUtils.canExecute(items, VDS.class, VdcActionType.MaintenanceVds)); @@ -2094,13 +2091,6 @@ getManualFenceCommand().setIsExecutionAllowed(items.size() == 1); getAssignTagsCommand().setIsExecutionAllowed(items.size() > 0); - - // System tree dependent actions. - boolean isAvailable = - !(getSystemTreeSelectedItem() != null && getSystemTreeSelectedItem().getType() == SystemTreeItemType.Host); - - getNewCommand().setIsAvailable(isAvailable); - getRemoveCommand().setIsAvailable(isAvailable); getSelectAsSpmCommand().setIsExecutionAllowed(isSelectAsSpmCommandAllowed(items)); -- To view, visit https://gerrit.ovirt.org/39846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6ff00bea3f65e8be6090b4408e57984bf67c2ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches