Eldan Shachar has posted comments on this change. Change subject: core/restapi/webadmin: Support clearing the cluster's emulated machine ......................................................................
Patch Set 9: (4 comments) https://gerrit.ovirt.org/#/c/37115/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java: Line 113: { Line 114: privateGuideCommand = value; Line 115: } Line 116: Line 117: private UICommand privateResetEmulatedMachineCommand; > please avoid the 'private' prefix in new code Done Line 118: Line 119: public UICommand getResetEmulatedMachineCommand() Line 120: { Line 121: return privateResetEmulatedMachineCommand; Line 491: UICommand tempVar2 = UICommand.createCancelUiCommand("Cancel", this); //$NON-NLS-1$ Line 492: model.getCommands().add(tempVar2); Line 493: } Line 494: Line 495: public void resetEmulatedMachine() > please put '{' on the same line, this is same as with the 'private' prefix Done Line 496: { Line 497: if (getWindow() != null) Line 498: { Line 499: return; Line 525: return; Line 526: } Line 527: Line 528: ArrayList<VdcActionParametersBase> prms = new ArrayList<VdcActionParametersBase>(); Line 529: for (Object vdsGroup : getSelectedItems()) > I believe ClusterListModel is now generic so getSelectedItems() should retu Done Line 530: { Line 531: ManagementNetworkOnClusterOperationParameters currentParam = new ManagementNetworkOnClusterOperationParameters(((VDSGroup) vdsGroup)); Line 532: currentParam.setForceResetEmulatedMachine(true); Line 533: prms.add(currentParam); Line 539: new IFrontendMultipleActionAsyncCallback() { Line 540: @Override Line 541: public void executed(FrontendMultipleActionAsyncResult result) { Line 542: Line 543: ConfirmationModel localModel = (ConfirmationModel) result.getState(); > please avoid using the 'target' facility from AsyncQuery. It is yet another Done Line 544: localModel.stopProgress(); Line 545: cancel(); Line 546: Line 547: } -- To view, visit https://gerrit.ovirt.org/37115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e1f70cbbe46fa54edda3f0aa9e56bfd576b8266 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
