Liron Aravot has posted comments on this change. Change subject: engine:Validate maximum number of hosts in DC.(#771699) ......................................................................
Patch Set 12: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java Line 38: if (!(!Guid.Empty.equals(getVds().getstorage_pool_id()) Line 39: && DbFacade.getInstance().getVdsSpmIdMapDao().get(getVdsId()) == null)) { Line 40: return false; Line 41: } Line 42: vds_spm_id_mapList = DbFacade.getInstance().getVdsSpmIdMapDao().getAll( will be done Line 43: getVds().getstorage_pool_id()); Line 44: if (vds_spm_id_mapList.size() >= Config.<Integer> GetValue(ConfigValues.MaxNumberOfHostsInStoragePool)) { Line 45: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_EXCEEDED_MAXIMUM_NUMBER_OF_HOSTS_IN_DATA_CENTER); Line 46: return false; -- To view, visit http://gerrit.ovirt.org/6514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches