Eli Mesika has posted comments on this change. Change subject: core: [RFE]Backup Awareness - DB and Alerts ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/39523/3/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 608: FENCE_OPERATION_FAILED=Power management ${Action} of Host ${VdsName} failed. Line 609: FENCE_OPERATION_USING_AGENT_AND_PROXY_STARTED=Executing power management ${Action} on Host ${Host} using Proxy Host ${ProxyHost} and Fence Agent ${AgentType}:${AgentIp}. Line 610: FENCE_OPERATION_USING_AGENT_AND_PROXY_FAILED=Execution of power management ${Action} on Host ${Host} using Proxy Host ${ProxyHost} and Fence Agent ${AgentType}:${AgentIp} failed. Line 611: ENGINE_NO_BACKUP=There is no backup available, please run engine-backup to prevent data loss in case of corruption. Line 612: ENGINE_NO_WARM_BACKUP=Backup is from ${Date} and is too old, please run engine-backup to prevent data loss in case of corruption. > Wouldn't be better to rephrase? Done Line 613: ENGINE_BACKUP_STARTED=Engine backup started. Line 614: ENGINE_BACKUP_COMPLETED=Engine backup completed successfully. Line 615: ENGINE_BACKUP_FAILED=Engine Backup failed. Line 616: RECONSTRUCT_MASTER_FAILED_NO_MASTER=No valid Data Storage Domains are available in Data Center ${StoragePoolName} (please check your storage infrastructure). Line 611: ENGINE_NO_BACKUP=There is no backup available, please run engine-backup to prevent data loss in case of corruption. Line 612: ENGINE_NO_WARM_BACKUP=Backup is from ${Date} and is too old, please run engine-backup to prevent data loss in case of corruption. Line 613: ENGINE_BACKUP_STARTED=Engine backup started. Line 614: ENGINE_BACKUP_COMPLETED=Engine backup completed successfully. Line 615: ENGINE_BACKUP_FAILED=Engine Backup failed. > Please change it to "Engine backup failed." so it conforms to other backup Done Line 616: RECONSTRUCT_MASTER_FAILED_NO_MASTER=No valid Data Storage Domains are available in Data Center ${StoragePoolName} (please check your storage infrastructure). Line 617: RECONSTRUCT_MASTER_DONE=Reconstruct Master Domain for Data Center ${StoragePoolName} completed. Line 618: RECONSTRUCT_MASTER_FAILED=Failed to Reconstruct Master Domain for Data Center ${StoragePoolName}. Line 619: IMPORTEXPORT_STARTING_EXPORT_VM=Starting export Vm ${VmName} to ${StorageDomainName} https://gerrit.ovirt.org/#/c/39523/3/packaging/dbscripts/upgrade/03_06_1210_add_backup_awareness.sql File packaging/dbscripts/upgrade/03_06_1210_add_backup_awareness.sql: Line 1: CREATE TABLE engine_backup_log( Line 2: db_name VARCHAR(64), Line 3: done_at TIMESTAMP WITH TIME ZONE, > Wouldn't "created" be a better name? I see no difference in clearness, both are good and therefor this is a matter of personal taste Line 4: is_passed BOOLEAN, Line 5: output_message TEXT, Line 6: PRIMARY KEY (db_name, done_at) Line 7: ); -- To view, visit https://gerrit.ovirt.org/39523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7824eb8a720bd654e94dada987aee19b9624a516 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
