Omer Frenkel has posted comments on this change. Change subject: core: VirtIO console access key management ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/39512/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetUserProfileCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetUserProfileCommand.java: Line 17: Line 18: import javax.inject.Inject; Line 19: Line 20: Line 21: public class SetUserProfileCommand<T extends SetUserProfileParameters> extends CommandBase<T> { this should be replaced with the standard way of manipulating business entities in the backend: add/update/remove UserProfileCommand(s) that receive the UserProfile object and save/update/delete it with the right validations and processing (like overriding the user id with getUserId().. Line 22: Line 23: static final private String SSH_RSA = "ssh-rsa"; Line 24: Line 25: @Inject https://gerrit.ovirt.org/#/c/39512/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetUserProfileParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetUserProfileParameters.java: Line 2: Line 3: public class SetUserProfileParameters extends VdcActionParametersBase { Line 4: private static final long serialVersionUID = -4168302609852555079L; Line 5: Line 6: private String sshPublicKey; should be the userProfile object Line 7: Line 8: public SetUserProfileParameters() { Line 9: } Line 10: -- To view, visit https://gerrit.ovirt.org/39512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ff5403823e752e695ebde76a4b7fb83e07099b6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
