Dudi Maroshi has posted comments on this change. Change subject: engine: Add KSM awaremess for NUMA optimization ......................................................................
Patch Set 2: (5 comments) All comments attended and fixed in patch set 6 https://gerrit.ovirt.org/#/c/39777/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 109: private Boolean autoConverge; Line 110: Line 111: private Boolean migrateCompressed; Line 112: Line 113: private Boolean ksmMergeAcrossNumaNodes; > I'd consider using boolean (primitive), there is no real use for 3 values h Done Line 114: Line 115: public VDSGroup() { Line 116: migrateOnError = MigrateOnErrorOptions.YES; Line 117: name = ""; https://gerrit.ovirt.org/#/c/39777/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java: Line 302: entity.getFencingPolicy().setHostsWithBrokenConnectivityThreshold(rs.getInt("hosts_with_broken_connectivity_threshold")); Line 303: entity.getFencingPolicy().setFencingEnabled(rs.getBoolean("fencing_enabled")); Line 304: entity.setAutoConverge((Boolean) rs.getObject("is_auto_converge")); Line 305: entity.setMigrateCompressed((Boolean) rs.getObject("is_migrate_compressed")); Line 306: entity.setKsmMergeAcrossNumaNodes((Boolean) rs.getObject("ksm_merge_across_nodes")); > use rs.getBoolean(..) Done Line 307: Line 308: return entity; Line 309: } Line 310: } https://gerrit.ovirt.org/#/c/39777/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java: Line 60: import org.ovirt.engine.ui.uicompat.IFrontendMultipleActionAsyncCallback; Line 61: import org.ovirt.engine.ui.uicompat.NotifyCollectionChangedEventArgs; Line 62: import org.ovirt.engine.ui.uicompat.UIConstants; Line 63: Line 64: import com.google.inject.Inject; > not related change. Done Line 65: Line 66: Line 67: Line 68: public class ClusterListModel<E> extends ListWithDetailsAndReportsModel<E, VDSGroup> implements ISupportSystemTreeContext { https://gerrit.ovirt.org/#/c/39777/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 115: @DefaultStringValue("Destination Volume") Line 116: String volumeSubTabGeoRepSlaveVolumeColumn(); Line 117: Line 118: @DefaultStringValue("User Name") Line 119: String volumeSubTabGeoRepSlaveUserColumn(); > related? Not related just displaced. I will Put it back. File removed from patch. Done Line 120: Line 121: @DefaultStringValue("Status") Line 122: String volumeSubTabGeoRepStatusColumn(); Line 123: https://gerrit.ovirt.org/#/c/39777/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml: Line 415: <d:InfoIcon Line 416: ui:field="skipFencingIfConnectivityBrokenInfo" /> Line 417: <e:ListModelListBoxEditor Line 418: ui:field="hostsWithBrokenConnectivityThresholdEditor" Line 419: addStyleNames="cpv_hostsWithBrokenConnectivityThresholdEditor_pfly_fix" /> > you've formatted the entire file... Done Line 420: </g:HorizontalPanel> Line 421: </g:FlowPanel> Line 422: </t:content> Line 423: </t:DialogTab> -- To view, visit https://gerrit.ovirt.org/39777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464542fd7a25ccb230ab22f45686dd3c22b394a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
