Martin Peřina has posted comments on this change. Change subject: core: Move FenceAgent into businessentities.pm ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39511/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/FenceValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/FenceValidatorTest.java: Line 7: static > These moving here isn't related to the patch Well, AFAIK our project code formatting settings formats imports like this: import static ... <EMPTY_LINE> import java.* <EMPTY_LINE> import javax.* <EMPTY_LINE> import * So if you really insist, I can separate those into standalone patch, but I'm not sure it's worth the effort. -- To view, visit https://gerrit.ovirt.org/39511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc3bf5f49bb1d9269d29ee19ff54af86a67d1fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
