Eliraz Levi has posted comments on this change. Change subject: webadmin: adding sync column to subtab net host ......................................................................
Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/35697/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQuery.java: Line 31: List<VdsNetworkInterface> vdsNetworkInterfaceList = getDbFacade().getInterfaceDao() Line 32: .getVdsInterfacesByNetworkId(getParameters().getId()); Line 33: final Map<Guid, VDS> vdsById = Entities.businessEntitiesById(vdsList); Line 34: List<PairQueryable<VdsNetworkInterface, VDS>> vdsInterfaceVdsPairs = Line 35: new ArrayList<PairQueryable<VdsNetworkInterface, VDS>>(); > now, with the injectable DAO, please declare them with @Inject as instance test aspects: implemented by getters. note - exposing the DAOst to package. can't implement by constructor as AbstractQueryTest is encapsulating the initialization of the query. (can be implemented if we will refactor AbstractQueryTest) Line 36: Network network = getDbFacade().getNetworkDao().get(getParameters().getId()); Line 37: HostNetworkQos qos = getDbFacade().getHostNetworkQosDao().get(network.getQosId()); Line 38: for (final VdsNetworkInterface vdsNetworkInterface : vdsNetworkInterfaceList) { Line 39: vdsInterfaceVdsPairs.add(new PairQueryable<VdsNetworkInterface, VDS>(vdsNetworkInterface, Line 37: HostNetworkQos qos = getDbFacade().getHostNetworkQosDao().get(network.getQosId()); Line 38: for (final VdsNetworkInterface vdsNetworkInterface : vdsNetworkInterfaceList) { Line 39: vdsInterfaceVdsPairs.add(new PairQueryable<VdsNetworkInterface, VDS>(vdsNetworkInterface, Line 40: vdsById.get(vdsNetworkInterface.getVdsId()))); Line 41: vdsNetworkInterface.setNetworkImplementationDetails(NetworkUtils.calculateNetworkImplementationDetails(network, > this line exceeds 120 chars, either reformat or extract the method call whi Done Line 42: qos, Line 43: vdsNetworkInterface)); Line 44: } Line 45: https://gerrit.ovirt.org/#/c/35697/9/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java: Line 49: private HostNetworkQos hostNetworkQos; Line 50: Line 51: @Before Line 52: public void setup(){ Line 53: MockitoAnnotations.initMocks(this); > iirc, this is not required if you define the class to run with @RunWith(Moc Done Line 54: } Line 55: Line 56: @Test Line 57: public void testExecuteQueryCommand() { -- To view, visit https://gerrit.ovirt.org/35697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd5d3a1e799d8ec0c8f8cea2d4ff7257d0234c2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
