Eli Mesika has posted comments on this change. Change subject: core: [RFE]Backup Awareness - DB ......................................................................
Patch Set 1: (8 comments) https://gerrit.ovirt.org/#/c/39523/1/packaging/dbscripts/audit_log_sp.sql File packaging/dbscripts/audit_log_sp.sql: Line 234: where vds_id = v_vds_id and log_type = v_log_type; Line 235: END; $procedure$ Line 236: LANGUAGE plpgsql; Line 237: Line 238: Create or replace FUNCTION DeleteAuditNoOrOldBackupAlert() > Sound better, will do Done Line 239: RETURNS VOID Line 240: AS $procedure$ Line 241: BEGIN Line 242: UPDATE audit_log set deleted = true https://gerrit.ovirt.org/#/c/39523/1/packaging/dbscripts/engine_backup_history_sp.sql File packaging/dbscripts/engine_backup_history_sp.sql: > will fix Done Line 1: CREATE OR REPLACE FUNCTION InsertEngineBackupHistory(v_db_name VARCHAR(64), Line 2: v_done_at TIMESTAMP WITH TIME ZONE , Line 3: v_passed BOOLEAN, Line 4: v_output_message TEXT) Line 34: v_status INTEGER, Line 35: v_output_message TEXT) Line 36: RETURNS VOID Line 37: AS $procedure$ Line 38: BEGIN > right, this patch set is only a draft , I did not managed to test it before Done Line 39: IF v_status = -1 THEN Line 40: PERFORM InsertEngineBackupHistory(v_db_name, v_done_at, false, v_output_message); Line 41: Line 42: INSERT INTO audit_log(log_time, log_type_name, log_type, severity, message) Line 36: RETURNS VOID Line 37: AS $procedure$ Line 38: BEGIN Line 39: IF v_status = -1 THEN Line 40: PERFORM InsertEngineBackupHistory(v_db_name, v_done_at, false, v_output_message); > will check again Done Line 41: Line 42: INSERT INTO audit_log(log_time, log_type_name, log_type, severity, message) Line 43: VALUES(v_done_at, ENGINE_BACKUP_FAILED, 9026, 9, v_output_message); Line 44: Line 39: IF v_status = -1 THEN Line 40: PERFORM InsertEngineBackupHistory(v_db_name, v_done_at, false, v_output_message); Line 41: Line 42: INSERT INTO audit_log(log_time, log_type_name, log_type, severity, message) Line 43: VALUES(v_done_at, ENGINE_BACKUP_FAILED, 9026, 9, v_output_message); > I meant that when i reviewed the patches, I'd expect to see the entities, c Done Line 44: Line 45: ELSIF v_status = 0 THEN Line 46: INSERT INTO audit_log(log_time, log_type_name, log_type, severity, message) Line 47: VALUES(v_done_at, ENGINE_BACKUP_STARTED, 9024, 1, v_output_message); Line 39: IF v_status = -1 THEN Line 40: PERFORM InsertEngineBackupHistory(v_db_name, v_done_at, false, v_output_message); Line 41: Line 42: INSERT INTO audit_log(log_time, log_type_name, log_type, severity, message) Line 43: VALUES(v_done_at, ENGINE_BACKUP_FAILED, 9026, 9, v_output_message); > will move the AuditLogType.java changes to this patch Done Line 44: Line 45: ELSIF v_status = 0 THEN Line 46: INSERT INTO audit_log(log_time, log_type_name, log_type, severity, message) Line 47: VALUES(v_done_at, ENGINE_BACKUP_STARTED, 9024, 1, v_output_message); https://gerrit.ovirt.org/#/c/39523/1/packaging/dbscripts/upgrade/03_06_1170_add_backup_awareness.sql File packaging/dbscripts/upgrade/03_06_1170_add_backup_awareness.sql: Line 1: CREATE TABLE engine_backup_history( > will rename Done Line 2: db_name VARCHAR(64), Line 3: done_at TIMESTAMP WITH TIME ZONE, Line 4: passed BOOLEAN, Line 5: output_message TEXT, Line 1: CREATE TABLE engine_backup_history( Line 2: db_name VARCHAR(64), Line 3: done_at TIMESTAMP WITH TIME ZONE, Line 4: passed BOOLEAN, > right , will fix Done Line 5: output_message TEXT, Line 6: PRIMARY KEY (db_name, done_at) Line 7: ); Line 8: -- To view, visit https://gerrit.ovirt.org/39523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7824eb8a720bd654e94dada987aee19b9624a516 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
