Ori Liel has posted comments on this change. Change subject: core: Refactor VdsStatic to use FenceProxySourceType ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39759/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 934: method Maybe better to modify existing invocations in this patch? I'm afraid we'll be stuck with these two signatures. They bring the same thing but have different names... let's get rid of the old one https://gerrit.ovirt.org/#/c/39759/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java: Line 283: callers Same comment as in Vds.java - maybe we can modify the invocations and get rid of the old signature already in the context of this patch? -- To view, visit https://gerrit.ovirt.org/39759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584ea587842cb8c4e31fa387d235d42cabea5648 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
